fix(appsec): enable SpanProcessor through the ddtrace product interface#647
Merged
florentinl merged 1 commit intomainfrom Aug 18, 2025
Merged
Conversation
florentinl
force-pushed
the
florentinl/fix-appsec-product-not-loaded
branch
from
b7d41a0 to
6604cf2
Compare
Contributor
purple4reina
left a comment
purple4reina
left a comment
There was a problem hiding this comment.
Looks good. Is there a reason you didn't put this in wrapper.py? It's where we currently have a lot of other conditional imports and startings of things. If it's alright, I'd rather move it there.
florentinl
force-pushed
the
florentinl/fix-appsec-product-not-loaded
branch
from
6604cf2 to
93445cc
Compare
Contributor
Author
|
It absolutely makes sense. I added it to the conditional imports for appsec in the wrapper.py. |
purple4reina
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the AppSec
ProductwhenDD_APPSEC_ENABLEDis set.Motivation
With DataDog/dd-trace-py@7bfeeb0 (to be released in 3.12), Appsec has moved from being enabled by default by the tracer to being enabled through a
Product.Outside of lambda (when started with
ddtrace-runorimport ddtrace.auto) products are automatically gathered by aProductManagerand started based on the configuration.This step does not happen in lambda and individual products that we want to make available to lambda need to be started manually. This is what I am doing for Appsec.
Testing Guidelines
Manually. I don't see how I could test this in unit tests. Suggestions welcome.
It will eventually be caught by system-tests once this PR is ready: DataDog/system-tests#4891
Additional Notes
Types of Changes
Check all that apply